removed invalid .then call using lib.promiseError which does not exis… #5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t anymore since 2016
archmoj
added
status: reviewable
bug
|
Thanks for the PR. LGTM. @alexcjohnson what do you think? Please create |
|
@archmoj Sorry for the inconvinience. I created to file and updated the branch. |
alexcjohnson
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Yep, this looks good to me. Thanks @jklimke! I'm surprised we missed that for so long... but that in itself gives me confidence that this is fine. I believe when lib.promiseError was introduced, browsers would silently swallow errors inside promise chains if you didn't explicitly catch them, but they're better now :)
💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t anymore since 2016
Fixes #1705 and closes #5807 that caused warnings on every redraw when promises were used intensively.
It was caused by attaching a "then" call with an error handler to promise executions, but the error handler function "lib.promiseError" was deleted.